-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45482/#review126285
-----------------------------------------------------------



Patch looks great!

Reviews applied: [45482]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 31, 2016, 7:42 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45482/
> -----------------------------------------------------------
> 
> (Updated March 31, 2016, 7:42 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3243
>     https://issues.apache.org/jira/browse/MESOS-3243
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> RUN: find . -name "*.[hc]pp" | xargs -P 4 sed -i 's/\bNULL\b/nullptr/g'
> 
> 
> Diffs
> -----
> 
>   src/authentication/cram_md5/authenticatee.cpp 
> 7d4994333428e5d8aa9ce6b85e0a7f42a0ddc4c8 
>   src/authentication/cram_md5/authenticator.cpp 
> 027eba4f433fff328d68c41005bc59c41c7ae668 
>   src/authentication/cram_md5/auxprop.cpp 
> d82d2d2f7793859772d89cc91bee09240624c613 
>   src/authorizer/local/authorizer.cpp 
> c744a16041c2466d3839a37fbee2bf86887bf4e1 
>   src/examples/balloon_executor.cpp 399218478a596387814d123290eeeb33102fad7a 
>   src/examples/example_module_impl.cpp 
> aeffdc0e95fa7badc8cfa09e2b57462e427fec55 
>   src/examples/load_generator_framework.cpp 
> b22a09e1749d4b523addacad99858d7b6bde3403 
>   src/examples/test_allocator_module.cpp 
> 1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
>   src/examples/test_anonymous_module.cpp 
> dd291cff3b5d47337e371cd2c1082fd6716af3fc 
>   src/examples/test_authorizer_module.cpp 
> 19ec7cd114562f74c660b83b39235127d25001ee 
>   src/examples/test_container_logger_module.cpp 
> 76dd494fa4c32514ba14b1f4498b588ac9051b4d 
>   src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a 
>   src/examples/test_http_authenticator_module.cpp 
> 8affdb60ae6336a2be5218c7bd04a4d5efeeb3f4 
>   src/examples/test_isolator_module.cpp 
> a4a2103b1e449837b95948c8b5c25e05c5d13860 
>   src/examples/test_qos_controller_module.cpp 
> f382fc443fa0a4545ba78dc28016e4d0a0dd16b1 
>   src/examples/test_resource_estimator_module.cpp 
> 229b2931e9129c194850f04051060d33bfa06570 
>   src/exec/exec.cpp 8f672602daf090dec032d2b684e407e5d043af9c 
>   src/files/files.hpp 90acb3406c46c164108deb559af71fb109a5773b 
>   src/java/jni/construct.cpp 0bfe6291e94a69a787c965fa3a3a90d2ebae8d72 
>   src/java/jni/convert.cpp f1a486d8d2f6d43efd89407c928734bd9715e591 
>   src/java/jni/org_apache_mesos_Log.cpp 
> 140b950136417eed7cba363a89537ed2f33832ff 
>   src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 
> 9a92ade5d54bd814353acb40170d7aa4d8fe4a77 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> c723e2d7bce98e6ac5ab587ce8c42fa9ba8b47e4 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 
> 4fd43ca31c6917e81ea1b331b8507ca42a2249cf 
>   src/java/jni/org_apache_mesos_state_Variable.cpp 
> 7a69b3d878e6eaa87bfaf56c0500e11efe4ac44d 
>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
> 23a89c3e5c5309a8a9b45c168fb61b12d89db1ec 
>   src/jvm/jvm.hpp d5023e4050d109ca97cedb05f85e1c24202ac3b0 
>   src/jvm/jvm.cpp 779f8b987e2673ca5ab924caf00eea09a0a79af5 
>   src/jvm/org/apache/zookeeper.hpp 7e9c3aaa9f0eed44994004f9e32ce7ce3cf6d335 
>   src/launcher/executor.cpp 4e9b4d9820f7c2f4cb1b3e16e2f4c8c13500693f 
>   src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 
>   src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
>   src/linux/fs.cpp 306beab4c294e6a83e469279f38a8423dabd3f19 
>   src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5 
>   src/linux/routing/diagnosis/diagnosis.cpp 
> 8b86a8864c08b078425dcc242d323763d6ec15dd 
>   src/linux/routing/filter/internal.hpp 
> 8690bf56472c318e85afb53d35494790ae4da27b 
>   src/linux/routing/internal.hpp 8f68119819f7c79ece1a13ac1894b1802ddc8e19 
>   src/linux/routing/link/internal.hpp 
> 8f05e5f513208c8f966bc324c9fe994a5807b051 
>   src/linux/routing/queueing/internal.hpp 
> 768ed325f9b259e150779eb3ad74f4e5d4bcc7a2 
>   src/linux/routing/route.cpp 4b33350dc3761e19121c29c0d090cfdae544e4ef 
>   src/linux/systemd.cpp 9f6e06cfcf6f5b38971ff75eb85326d043140b4b 
>   src/local/local.hpp f4ae285edc30a0fb1c960d50dfb1a859b2eae166 
>   src/local/local.cpp e777ea2938a23db8b407676a0f7e635e63d032fa 
>   src/log/leveldb.cpp ba2f62bc97e4a0eaa8a54824551686467db4b9e4 
>   src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 
>   src/log/tool/benchmark.hpp 3051b6ff025252d2c770b0a70d6a66f4f34d7e69 
>   src/log/tool/benchmark.cpp 770c6d85fec76826ca8369b2afc721c07899e32f 
>   src/log/tool/initialize.hpp 99c80061442c6379978f907c80a7e9d54a015f04 
>   src/log/tool/initialize.cpp bd1e9ef1922ae972a5999b6e7412e08eac92c1ac 
>   src/log/tool/read.hpp 937ae8f15f5e2227247ab43aa24c887c13c3cf2c 
>   src/log/tool/read.cpp b9e90e44c8cd7351767e523af338d8c662e0848c 
>   src/log/tool/replica.hpp c25bb09abc4391614c7a35b9ca91d678a745ffdd 
>   src/log/tool/replica.cpp 49415821a32960c78192b89f9a0f2067b9157a63 
>   src/logging/logging.cpp 20d2f6341bd39fc5d056f1046d258d006fc602e4 
>   src/master/allocator/mesos/hierarchical.hpp 
> e979fdf60da1409d1c2d08f0e9f03cef067506dd 
>   src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 
>   src/master/contender.cpp 846f516edcc63affd05158e9e5235e6d97f67f15 
>   src/master/http.cpp 03d4ebabfba1bf711fc0897801a989ac3c72f9f1 
>   src/master/main.cpp 58561cffa440aaf1293e9ffe19b5685e6d2f1952 
>   src/master/master.hpp 1751ee1fc4d3e15df018be8bfd4f8ef2a0e32abd 
>   src/master/master.cpp 655b0b8d0156b44914578a1241beb1fb7c92ca23 
>   src/master/validation.cpp 9c9e42283baa6e49d86af2ce7222131ce53ccaff 
>   src/module/manager.hpp 9944af0daf6c9cb5a8ff338099401b1db88ee237 
>   src/module/manager.cpp 8c9aaf7cd00c904daba9994a99df9e1329831c01 
>   src/python/executor/src/mesos/executor/mesos_executor_driver_impl.cpp 
> 843771ae5b4f7e283d85c093e63c235dc753397d 
>   src/python/executor/src/mesos/executor/module.cpp 
> f8c63821db616475b95c3d1687893c251fa2daca 
>   src/python/executor/src/mesos/executor/proxy_executor.cpp 
> b9c8a2d131e5aadf6fa79af023bb34ae5a3cebba 
>   src/python/native_common/common.hpp 
> 166adb32978260750898537e8f45e4f3bbd19c79 
>   src/python/scheduler/src/mesos/scheduler/mesos_scheduler_driver_impl.cpp 
> 78dc298ec19a61cd491b2b43b463db67528c5526 
>   src/python/scheduler/src/mesos/scheduler/module.cpp 
> 62eaf3166c4ebef42665358e8da438b2e3afba20 
>   src/python/scheduler/src/mesos/scheduler/proxy_scheduler.cpp 
> 3d8f3bfc9cbff761822580310432177d00450f51 
>   src/sched/sched.cpp d989cb5f35d314dc2e03617bfdbd4b18d4efcf91 
>   src/scheduler/scheduler.cpp 5263a9c549de299434bb835c12c87615b595991a 
>   src/slave/container_logger.cpp 85b8c1d3a42baba14741996d791926816b252742 
>   src/slave/container_loggers/lib_logrotate.cpp 
> 1f228806da32832c9ca1ae4defcd1bdc154adc18 
>   src/slave/container_loggers/logrotate.cpp 
> 7d36c052ff7a180b45ca265fb7ff4c6900d98d64 
>   src/slave/containerizer/docker.cpp c5007a311ae9c1766dd4522ccbddbdb506d4ae4e 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> 9fc7c48f99155750fd3c18c7c102507e2726362b 
>   src/slave/containerizer/mesos/isolators/namespaces/pid.cpp 
> 5970d22e7198236d22c55de6153f465ed5f5fd7a 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 1c8e231813c0579b79681c5d18b1f799a727ead7 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 323c84a3d960a196d8ba87f753814e9d43a07957 
>   src/slave/containerizer/mesos/launch.cpp 
> dc7bebf8d0f3e36c6d41af4e0e8ffc438b6cd86c 
>   src/slave/containerizer/mesos/mount.cpp 
> bf17b015e45579882fd31248e8609eec6d58a9da 
>   src/slave/containerizer/mesos/provisioner/backends/bind.cpp 
> 9b9f0b9e99a0fc0e9bad8fb2dad41acdc0ca1da1 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 
> 93892a75fe3ddd5c7b2a023b63f6d0fa83eeb97d 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 8a4938ebe4e00779e88e7c538445e9ffd51202e2 
>   src/slave/http.cpp 7a872c6e21b115500c5291b7cb9fb240ec9dc8ed 
>   src/slave/qos_controllers/load.cpp dd44f9209ad283bfea95f16a8c1017e309757f23 
>   src/slave/qos_controllers/noop.cpp dc40f43e89212b77611522b0794c675a5ea1c53e 
>   src/slave/resource_estimators/fixed.cpp 
> c858a48bc137185d1e1e24a20f6b75b0dd7912ff 
>   src/slave/resource_estimators/noop.cpp 
> 66c646def36c1050b01d55f9fe6561ca5eed6148 
>   src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa 
>   src/slave/status_update_manager.cpp 
> f6a9b3b6616abee9c55bf731855ee9b3b98606ac 
>   src/state/leveldb.cpp f925a73856075f08c4af2af0fcaae8e81358667e 
>   src/state/zookeeper.cpp 5578fa5f0b86f8dfeabf1be2984bfa0443cc049c 
>   src/tests/containerizer/cgroups_tests.cpp 
> ecd83c7427353790d93e98ab3d62c46a8da43c96 
>   src/tests/containerizer/memory_test_helper.cpp 
> 92579a28336b3c15ba7fdbb4a9f769ac7182aeb6 
>   src/tests/containerizer/routing_tests.cpp 
> 4ebb01213ce20f954c2633df95e898cf66a2d9e9 
>   src/tests/environment.cpp 90dbe9488bda6af26143934e196aab0d69dccec3 
>   src/tests/group_tests.cpp acfb1485f655f3bc39ee68448ba041af366f70f5 
>   src/tests/master_contender_detector_tests.cpp 
> 616a2c7316adc116071feaad95e3901ff66213ad 
>   src/tests/mesos.hpp a35371d7c1fcb9dbbe8a18c80522deb6bf789ad8 
>   src/tests/mesos.cpp 77d49cc65e08f040b0d2010cd083928e4ff8b7cd 
>   src/tests/module_tests.cpp 950d8e4ac49bc081df5cdf6850b4a5b438e67737 
>   src/tests/registrar_tests.cpp 39caf9bb950c0b229a66becb039c7a830a18f6bc 
>   src/tests/script.cpp 5f2e2729b1d95b061bf3cbe0a052b397e366277d 
>   src/tests/slave_tests.cpp 57fc50360eae85819ae6ce714b0c3c4c1867b2b8 
>   src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 
>   src/tests/zookeeper.hpp 2a4e829808a06f1439cc377a6e56169eb129f21f 
>   src/tests/zookeeper_test_server.cpp 
> 0dc041fef8973d35114b9f76a6a4002853884670 
>   src/tests/zookeeper_tests.cpp 6bde10b9ae9a644d3506abb285786200dc2fbe94 
>   src/zookeeper/group.cpp ca5e99d09825bf5ace7ba59c95266c51e246974f 
>   src/zookeeper/zookeeper.hpp 9191df50dd5b601491a86584f7184a31a6151ca5 
>   src/zookeeper/zookeeper.cpp 02fa158a37ddaf045bdf6403c134d03a02c74833 
> 
> Diff: https://reviews.apache.org/r/45482/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Reply via email to