-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44674/#review126465
-----------------------------------------------------------




src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp (lines 192 
- 209)
<https://reviews.apache.org/r/44674/#comment189449>

    Can we move this logic into docker spec file:
    ```
    Result<int> spec::getRegistryPort(const string& registry);
    Result<string> spec::getRegistryScheme(const string& registry);
    Try<string> spec::getRegistryHost(const string& registry);
    ```


- Jie Yu


On March 17, 2016, 4:57 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44674/
> -----------------------------------------------------------
> 
> (Updated March 17, 2016, 4:57 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4939
>     https://issues.apache.org/jira/browse/MESOS-4939
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported image name specified with private registry prefix.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 6d637ed14f35feb554c8fcc63a7a7e046aaca574 
> 
> Diff: https://reviews.apache.org/r/44674/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> sudo ./bin/mesos-test.sh --gtest_filter="ProvisionerDockerRegistryPullerTest"
> 
> Tested with private registry localhost:80/ubuntu
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Reply via email to