-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44674/#review126700
-----------------------------------------------------------




src/docker/spec.cpp (lines 103 - 105)
<https://reviews.apache.org/r/44674/#comment189721>

    Always good to check it explicitly, but we should not get any segfault 
without this check.


- Gilbert Song


On April 2, 2016, 1:20 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44674/
> -----------------------------------------------------------
> 
> (Updated April 2, 2016, 1:20 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4939
>     https://issues.apache.org/jira/browse/MESOS-4939
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported image name specified with private registry prefix.
> 
> 
> Diffs
> -----
> 
>   include/mesos/docker/spec.hpp 5fb6647cc02aa64fa9305b1ec6db9d6d81caf5f7 
>   src/docker/spec.cpp 07c0b87ee1a3b6981adfc96f5a7add6f625374c1 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> d3eccd9902a7896d52e6c79b13bd389bb6380b8d 
> 
> Diff: https://reviews.apache.org/r/44674/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> sudo ./bin/mesos-test.sh --gtest_filter="ProvisionerDockerRegistryPullerTest"
> 
> Tested with private registry localhost:80/ubuntu
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Reply via email to