> On March 31, 2016, 5:12 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/utils.cpp, line 336 > > <https://reviews.apache.org/r/44946/diff/11/?file=1318424#file1318424line336> > > > > Plural? > > > > We often use a trailing understore: `char* directory_[]`. > > (s/path/directory/ is due to the suggestion on generalizing the method) > > > > Also, no padding space in `{}`. > > > > Therefore: > > > > ``` > > char* directory_[] = {const_cast<char*>(path.c_str()), nullptr}; > > ```
This is identical to the code in ``src/linux/cgroups.cpp``. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review126200 ----------------------------------------------------------- On March 30, 2016, 10:18 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44946/ > ----------------------------------------------------------- > > (Updated March 30, 2016, 10:18 p.m.) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Bugs: MESOS-4828 > https://issues.apache.org/jira/browse/MESOS-4828 > > > Repository: mesos > > > Description > ------- > > Add utility functions to manipulate XFS project quotas. > > > Diffs > ----- > > src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 > src/slave/containerizer/mesos/isolators/xfs/utils.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/xfs/utils.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44946/diff/ > > > Testing > ------- > > Make check. Manual verification. Tests in subsequent patches. > > > Thanks, > > James Peach > >
