----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review125072 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp (line 305) <https://reviews.apache.org/r/44946/#comment187813> More strictly: `0u`. Plus, it would be clearer is it is defined as a constant. // A sentinel project ID that indicates that the file/directory is not associated with a valid project ID. constexpr prid_t NON_PROJECT_ID = 0u; As mentioned in another review, I think we can limit the use of this sentinel in the util. - Jiang Yan Xu On March 22, 2016, 4:24 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44946/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 4:24 p.m.) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Bugs: MESOS-4828 > https://issues.apache.org/jira/browse/MESOS-4828 > > > Repository: mesos > > > Description > ------- > > Add utility functions to manipulate XFS project quotas. > > > Diffs > ----- > > src/Makefile.am 6552e48eab2708a28dd69adba3ec759cb5aeca4c > src/slave/containerizer/mesos/isolators/disk/xfs/utils.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44946/diff/ > > > Testing > ------- > > Make check. Manual verification. Tests in subsequent patches. > > > Thanks, > > James Peach > >
