----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45620/#review126713 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/cni/cni.hpp (line 95) <https://reviews.apache.org/r/45620/#comment189747> Can you please clarify why making `networkInfo` as an `Option`? Is there any chances that `status()` is called before `ContainerNetwork.networkInfo` is set in `prepare()` and `_recover()`? - Qian Zhang On April 3, 2016, 2:44 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45620/ > ----------------------------------------------------------- > > (Updated April 3, 2016, 2:44 a.m.) > > > Review request for mesos, Avinash sridharan and Qian Zhang. > > > Bugs: MESOS-4764 > https://issues.apache.org/jira/browse/MESOS-4764 > > > Repository: mesos > > > Description > ------- > > This patch also does a few minor cleanups. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp > b1173d5adee6b4eb45dbed5e693f40ffb5275210 > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > af5f49007e0afe57006c9db940611e56eb75a621 > > Diff: https://reviews.apache.org/r/45620/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
