> On April 3, 2016, 2:08 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/containerizer.hpp, lines 180-182 > > <https://reviews.apache.org/r/44822/diff/4/?file=1323355#file1323355line180> > > > > one line
The remain spaces is not allowed to one line here. Or I missunderstanding anything here? > On April 3, 2016, 2:08 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 424 > > <https://reviews.apache.org/r/44822/diff/4/?file=1323356#file1323356line424> > > > > What about s/newRecoverables/mesosRevocables or > > s/newRecoverables/filterRevocables and add some comments here for why do we > > need filter here? > > > > // ContainerState revocabale info which only > > // include mesos containerizers. > > list<ContainerState> filterRecoverables; `filterRevocables` more meaningful, thanks a lot! > On April 3, 2016, 2:08 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 426-429 > > <https://reviews.apache.org/r/44822/diff/4/?file=1323356#file1323356line426> > > > > What about using reference here? > > > > const ExecutorInfo& executorInfo = recoverable.executor_info(); > > const ContainerID& containerId = recoverable.container_id(); > > const FrameworkID& frameworkId = executorInfo.framework_id(); > > const ExecutorID& executorId = executorInfo.executor_id(); I remember mesos style guide didn't alllow const temporary refrence. https://issues.apache.org/jira/browse/MESOS-2629 - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44822/#review126727 ----------------------------------------------------------- On April 3, 2016, 2:11 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44822/ > ----------------------------------------------------------- > > (Updated April 3, 2016, 2:11 p.m.) > > > Review request for mesos, Benjamin Hindman, Ian Downes, Jie Yu, Till > Toenshoff, and Timothy Chen. > > > Bugs: MESOS-5085 > https://issues.apache.org/jira/browse/MESOS-5085 > > > Repository: mesos > > > Description > ------- > > Remove `SlaveState` in `MesosContainerizer` during recover. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > a6e3a8b43fb7591ff6f23b019a062696c8bfb719 > src/slave/containerizer/mesos/containerizer.cpp > a5dd22380066aa85de04d485052084e2629681c0 > src/tests/containerizer/mesos_containerizer_tests.cpp > 09742ff21513dc2570684d384b257868dd57a9ce > > Diff: https://reviews.apache.org/r/44822/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
