> On April 3, 2016, 2:08 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/containerizer.hpp, lines 180-182 > > <https://reviews.apache.org/r/44822/diff/4/?file=1323355#file1323355line180> > > > > one line > > haosdent huang wrote: > The remain spaces is not allowed to one line here. Or I missunderstanding > anything here? > > Guangya Liu wrote: > Not quite get your point, what about following? > > process::Future<Nothing> _recover(const hashset<ContainerID>& orphans);
`const list<ContainerState>& recoverables` is necessary here. So could move change the interface to `process::Future<Nothing> _recover(const hashset<ContainerID>& orphans);` - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44822/#review126727 ----------------------------------------------------------- On April 3, 2016, 2:11 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44822/ > ----------------------------------------------------------- > > (Updated April 3, 2016, 2:11 p.m.) > > > Review request for mesos, Benjamin Hindman, Ian Downes, Jie Yu, Till > Toenshoff, and Timothy Chen. > > > Bugs: MESOS-5085 > https://issues.apache.org/jira/browse/MESOS-5085 > > > Repository: mesos > > > Description > ------- > > Remove `SlaveState` in `MesosContainerizer` during recover. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > a6e3a8b43fb7591ff6f23b019a062696c8bfb719 > src/slave/containerizer/mesos/containerizer.cpp > a5dd22380066aa85de04d485052084e2629681c0 > src/tests/containerizer/mesos_containerizer_tests.cpp > 09742ff21513dc2570684d384b257868dd57a9ce > > Diff: https://reviews.apache.org/r/44822/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
