----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126734 -----------------------------------------------------------
@yongtang, Thank you very much for your patch and follow up continuously! The patch looks good to me and I left my personal comments on it. Feel free to drop it if you have better ideas. support/mesos-style.py (line 39) <https://reviews.apache.org/r/45033/#comment189802> I think use ``` for path in source_paths ``` better support/mesos-style.py (line 41) <https://reviews.apache.org/r/45033/#comment189803> Variable name and space ``` line_no = 1 ``` support/mesos-style.py (line 42) <https://reviews.apache.org/r/45033/#comment189804> I suggest use `source_file` instead of `p`. `p` looks confusing here. support/mesos-style.py (line 43) <https://reviews.apache.org/r/45033/#comment189800> Need add space between `=` ``` m = re.match... ``` support/mesos-style.py (line 45) <https://reviews.apache.org/r/45033/#comment189801> Add space between `+` as well. By the way, this line overflow 80 characters limit? I think could break this line to few lines and add some extra local variables. And I think `Ln` and `Pos` is unclear, I suggest use another clear name. And `m.start() + 1` is because of you want to the base of index is start from `1` in display message? support/mesos-style.py (line 47) <https://reviews.apache.org/r/45033/#comment189805> Actually you could use ``` for line_no, line in enumerate(source_file): ... ``` so that you don't need this wired way here. support/mesos-style.py (line 147) <https://reviews.apache.org/r/45033/#comment189806> How about use `no_ascii_errors`? - haosdent huang On April 2, 2016, 1:41 a.m., Yong Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45033/ > ----------------------------------------------------------- > > (Updated April 2, 2016, 1:41 a.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd > Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi > Xiao. > > > Bugs: MESOS-4033 > https://issues.apache.org/jira/browse/MESOS-4033 > > > Repository: mesos > > > Description > ------- > > This review request tries to add addition check in mesos-style.pl > for checking non-ascii characters. It scans .cpp, .hpp, .cc, .h > files and report error if non-ascii characters exists. > > As part of this review request, two non-ascii characters are identified > in versioning.md (one in Ln 85 and another in Ln 96) and are corrected > accordingly. > > Note: .md scan is skipped based on feedback from review request. > > > Diffs > ----- > > docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b > support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162 > > Diff: https://reviews.apache.org/r/45033/diff/ > > > Testing > ------- > > Tested manually and found two non ascii characters in docs/versioning.md > (fixed as part of this review request). > > > Thanks, > > Yong Tang > >
