> On April 3, 2016, 4:21 p.m., Kevin Klues wrote: > > Thanks Yong for all your work on this! > > > > Just a few comments about style and one comment regarding the use of > > `re.match()` instead of `re.search()`. > > > > Please see my patch on github which applies all of the comments I've left: > > https://github.com/klueska-mesosphere/mesos/commits/r/yongtang/non-ascii > > > > Thanks! > > haosdent huang wrote: > Seems our reviews went into thread competition in real life. Sorry to > forgot check this before I public my comments.
Thanks a lot for all the detailed reviews, Kevin and haosdent. And I really appreciate that. The review request has been updated. Please let me know if there are any additional issues. Again, thanks a lot for all the efforts! - Yong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126733 ----------------------------------------------------------- On April 3, 2016, 7:46 p.m., Yong Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45033/ > ----------------------------------------------------------- > > (Updated April 3, 2016, 7:46 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd > Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi > Xiao. > > > Bugs: MESOS-4033 > https://issues.apache.org/jira/browse/MESOS-4033 > > > Repository: mesos > > > Description > ------- > > This review request tries to add addition check in mesos-style.pl > for checking non-ascii characters. It scans .cpp, .hpp, .cc, .h > files and report error if non-ascii characters exists. > > As part of this review request, two non-ascii characters are identified > in versioning.md (one in Ln 85 and another in Ln 96) and are corrected > accordingly. > > Note: .md scan is skipped based on feedback from review request. > > Note: This commit includes patches from Kevin Klues and haosdent. > > > Diffs > ----- > > docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b > support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162 > > Diff: https://reviews.apache.org/r/45033/diff/ > > > Testing > ------- > > Tested manually and found two non ascii characters in docs/versioning.md > (fixed as part of this review request). > > > Thanks, > > Yong Tang > >
