----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44441/#review126880 -----------------------------------------------------------
src/cli/execute.cpp (line 284) <https://reviews.apache.org/r/44441/#comment189971> Could you test --command="sh,-c,echo 'hello world'" and --command="sh,-c,echo 'hello,world'" It seems to me that maybe we should add a flag for arguement, since that is identical to developer's behavior on writting a framework. Also, tokenize seems not sufficient enough to me. Let's discuss today. src/cli/execute.cpp (line 287) <https://reviews.apache.org/r/44441/#comment189968> This is incorrect. We handle this merging operation in runtime isolator. - Gilbert Song On April 3, 2016, 6:42 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44441/ > ----------------------------------------------------------- > > (Updated April 3, 2016, 6:42 a.m.) > > > Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, > and Jie Yu. > > > Bugs: MESOS-4882 > https://issues.apache.org/jira/browse/MESOS-4882 > > > Repository: mesos > > > Description > ------- > > Treated command as executable value and arguments in mesos-execute. > > > Diffs > ----- > > src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 > > Diff: https://reviews.apache.org/r/44441/diff/ > > > Testing > ------- > > 1) with docker entry point > root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute > --master=192.168.56.12:5050 --name=test_mesos --docker_image=busybox:latest > --containerizer=mesos --no-shell > I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0 > Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0000 > task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0 > Received status update TASK_RUNNING for task test_mesos > > 2) With command 1 > root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute > --master=192.168.56.12:5050 --name=test_mesos --docker_image=busybox:latest > --containerizer=mesos --no-shell --command="ls,/etc/passwd" > I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0 > Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001 > task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0 > Received status update TASK_RUNNING for task test_mesos > Received status update TASK_FINISHED for task test_mesos > > 3) With command 2 > root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute > --master=192.168.56.12:5050 --name=test_mesos --docker_image=busybox:latest > --containerizer=mesos --no-shell --command="ls,/etc/passwd,/etc/passwd" > I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0 > Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002 > task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0 > Received status update TASK_RUNNING for task test_mesos > Received status update TASK_FINISHED for task test_mesos > > 4) With command 3 > root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute > --master=192.168.56.12:5050 --name=test_mesos --docker_image=busybox:latest > --containerizer=mesos --no-shell --command="cat,/etc/passwd,/etc/passwd" > I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0 > Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003 > task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0 > Received status update TASK_RUNNING for task test_mesos > Received status update TASK_FINISHED for task test_mesos > > > Thanks, > > Guangya Liu > >
