> On 四月 2, 2016, 2:38 p.m., haosdent huang wrote:
> > src/cli/execute.cpp, line 283
> > <https://reviews.apache.org/r/44441/diff/3/?file=1320213#file1320213line283>
> >
> >     How to handle those command parameters contains "," here? For example, 
> > if user want to try "cat 'a,b'".
> 
> Alexander Rukletsov wrote:
>     Yeah, and if the user wants "echo 'hello world'"? I'm fine with 
> consolidating command and arguments flag, but let's make sure we parse it 
> correcly. Maybe we can do it the way docker does? I.e. `["command", "arg1", 
> "arg2", ...]`; we can leverage our JSON parser for this, I believe 
> `tockenize()` is not enough. Also, I would like us manually test various 
> inputs and capture them in the testing done section. We may later want to 
> automate these tests in a staging cluster.

Yes, I will test more cases. 

@haosdent, for your case, you should run the command as 
`--command="cat,/etc/passwd,/etc/passwd"`

@Alexr, does the strings::tokenize(command.get(), ",") enough? Why need JSON 
parser?


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44441/#review126690
-----------------------------------------------------------


On 四月 2, 2016, 3:01 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44441/
> -----------------------------------------------------------
> 
> (Updated 四月 2, 2016, 3:01 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4882
>     https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/44441/diff/
> 
> 
> Testing
> -------
> 
> ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos 
> --docker_image=busybox:latest --containerizer=mesos --no-shell  
> --command="ls,/etc/passwd" 
> I0307 15:48:09.834506 27450 sched.cpp:222] Version: 0.29.0
> I0307 15:48:09.841404 27468 sched.cpp:326] New master detected at 
> master@192.168.56.12:5050
> I0307 15:48:09.843992 27468 sched.cpp:336] No credentials provided. 
> Attempting to register without authentication
> I0307 15:48:09.848901 27468 sched.cpp:703] Framework registered with 
> a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> task test_mesos submitted to slave 6fa2afa1-768b-4f2e-9c69-9f1017634e72-S2
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> I0307 15:48:10.284418 27466 sched.cpp:1903] Asked to stop the driver
> I0307 15:48:10.284494 27466 sched.cpp:1143] Stopping framework 
> 'a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Reply via email to