> On April 6, 2016, 11:14 p.m., Anand Mazumdar wrote:
> > Thanks for bearing with me. Most of the new comments are from the previous 
> > version itself. My bad, should have been caught by me earlier.

Thanks Anand for all the comments, you are really rigorous and all your review 
comments are very helpful!


> On April 6, 2016, 11:14 p.m., Anand Mazumdar wrote:
> > src/launcher/http_command_executor.cpp, line 1082
> > <https://reviews.apache.org/r/44424/diff/6/?file=1325941#file1325941line1082>
> >
> >     Nit: s/mesos::v1::FrameworkID/FrameworkID
> >     
> >     You already have a `using` declaration for this.

That `using` is in the scope of `mesos::slave` namespace, but this code is out 
of that scope.


> On April 6, 2016, 11:14 p.m., Anand Mazumdar wrote:
> > src/launcher/http_command_executor.cpp, line 1083
> > <https://reviews.apache.org/r/44424/diff/6/?file=1325941#file1325941line1083>
> >
> >     Ditto

Ditto.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44424/#review127329
-----------------------------------------------------------


On April 5, 2016, 8:36 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44424/
> -----------------------------------------------------------
> 
> (Updated April 5, 2016, 8:36 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
>     https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated http_command_executor.cpp to use v1 API.
> 
> 
> Diffs
> -----
> 
>   src/launcher/http_command_executor.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44424/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Reply via email to