> On April 9, 2016, 2:52 a.m., Anand Mazumdar wrote:
> > src/launcher/http_command_executor.cpp, lines 82-94
> > <https://reviews.apache.org/r/44424/diff/7/?file=1329958#file1329958line82>
> >
> >     Let's move this all out of the `mesos::internal` namespace. We 
> > typically have `using` declarations at the top of the cpp file.
> >     
> >     Also, I synced up with Vinod offline let's put all the cpp code in 
> > `mesos::v1::internal` namespace. Then, you won't have all the naming 
> > ambiguities that made you add the using declarations in `mesos::internal` 
> > namespace.

Thanks Anand! And I think we do not need the followings since we are already in 
`mesos::v1` namespace.
using mesos::v1::CommandInfo;
using mesos::v1::FrameworkInfo;
using mesos::v1::KillPolicy;
using mesos::v1::TaskID;
using mesos::v1::TaskInfo;
using mesos::v1::TaskState;
using mesos::v1::TaskStatus;


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44424/#review127791
-----------------------------------------------------------


On April 7, 2016, 10:13 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44424/
> -----------------------------------------------------------
> 
> (Updated April 7, 2016, 10:13 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
>     https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated http_command_executor.cpp to use v1 API.
> 
> 
> Diffs
> -----
> 
>   src/launcher/http_command_executor.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44424/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Reply via email to