----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44424/#review128522 -----------------------------------------------------------
src/launcher/http_command_executor.cpp (lines 286 - 287) <https://reviews.apache.org/r/44424/#comment191955> No need to capture taskId because you can get it from `task`? src/launcher/http_command_executor.cpp (line 405) <https://reviews.apache.org/r/44424/#comment191961> Instead of using underscores, the older version, where it explicitly uses fs:: namespace, looks cleaner. src/launcher/http_command_executor.cpp (line 702) <https://reviews.apache.org/r/44424/#comment191957> does the compiler require this namespacing to disambiguate? src/launcher/http_command_executor.cpp (lines 736 - 741) <https://reviews.apache.org/r/44424/#comment191959> Lets fix this hack now that the executor receives acknowledgements for status updates. The executor can terminate after it receives an ACK for a terminal status update. Can you add a TODO here and fix it in a separate review? src/launcher/http_command_executor.cpp (line 863) <https://reviews.apache.org/r/44424/#comment191962> kill this in favor of `task` below. - Vinod Kone On April 9, 2016, 8:40 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44424/ > ----------------------------------------------------------- > > (Updated April 9, 2016, 8:40 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-3558 > https://issues.apache.org/jira/browse/MESOS-3558 > > > Repository: mesos > > > Description > ------- > > Updated http_command_executor.cpp to use v1 API. > > > Diffs > ----- > > src/launcher/http_command_executor.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44424/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >