> On March 22, 2016, 8:30 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp, line 200 > > <https://reviews.apache.org/r/45022/diff/1/?file=1305011#file1305011line200> > > > > Why do we need this? I would much prefer to remove this. > > Alex Clemmer wrote: > What would you like to see instead? This is how the tests were initially > concieved before they moved here, IIRC. I'm happy to change it, as I didn't > set out to do this myself.
Ah I see. Sorry about that. This is only used in one place: ```cpp hashset<string> expectedListing = EMPTY; ``` We can just do the following instead: ```cpp hashset<string> expectedListing; ``` - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45022/#review124867 ----------------------------------------------------------- On April 7, 2016, 11:08 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45022/ > ----------------------------------------------------------- > > (Updated April 7, 2016, 11:08 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-4415 > https://issues.apache.org/jira/browse/MESOS-4415 > > > Repository: mesos > > > Description > ------- > > We currently depend on arcane "POSIX-like" Windows APIs like `::remove`. > This API is incompatible with NT paths -- which we will eventually have > to transition to for the Windows integration -- and has no documented > behavior interacting with subsystems like the driver subsystem, which is > required for symlinks. > > This commit will move us to proper core Windows API equivalents for > `::remove`. > > Review: https://reviews.apache.org/r/45022 > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 7bd4bfbc2ec5922879dcefddc12137336b11be52 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rm.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp > 52568b303c03fd57b81f6cc67782444ce734dd41 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rm.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp > 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 > > Diff: https://reviews.apache.org/r/45022/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
