-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45926/#review127827
-----------------------------------------------------------


Fix it, then Ship it!





src/cli/execute.cpp (line 85)
<https://reviews.apache.org/r/45926/#comment191205>

    Not yours, but s/IP1:PORT1/IP:PORT/



src/cli/execute.cpp (lines 97 - 100)
<https://reviews.apache.org/r/45926/#comment191207>

    Might be nice to note that this is ignored if `flags.shell` is false.



src/cli/execute.cpp (line 99)
<https://reviews.apache.org/r/45926/#comment191206>

    s/shell command, an/shell command, or an/



src/cli/execute.cpp (line 108)
<https://reviews.apache.org/r/45926/#comment191208>

    This format (`/path/to/file`) is deprecated, so I'd vote for removing it 
from the description.


- Joseph Wu


On April 8, 2016, 5:39 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45926/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 5:39 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/45926/diff/
> 
> 
> Testing
> -------
> 
> See the last patch in the chain: https://reviews.apache.org/r/45927/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to