> On April 9, 2016, 2:24 a.m., Guangya Liu wrote:
> > src/cli/execute.cpp, line 100
> > <https://reviews.apache.org/r/45926/diff/1/?file=1337076#file1337076line100>
> >
> > I think we cannot sepcify the entrypoint for container here, the
> > entrypoint was runtime configuration and was get from docker iamge.
>
> Alexander Rukletsov wrote:
> Why not? That's exactly what you do in https://reviews.apache.org/r/44441/
>
> Guangya Liu wrote:
> In my understanding, what I did in r44441 is for
> https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/isolators/docker/runtime.cpp#L248-L256
> , but the entrypoint is
> https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/isolators/docker/runtime.cpp#L240-L248
> , make sense?
No, it doesn't. You have branching in your patch `if (command.isSome()) {`
which switches between the two cases and hence covers them both.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45926/#review127945
-----------------------------------------------------------
On April 11, 2016, 7 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45926/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 7 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/cli/execute.cpp 763dd26c359d1dd92c6e0365e4808b673efb1f40
>
> Diff: https://reviews.apache.org/r/45926/diff/
>
>
> Testing
> -------
>
> See the last patch in the chain: https://reviews.apache.org/r/45927/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
