> On April 8, 2016, 11:10 a.m., Joseph Wu wrote: > > src/cli/execute.cpp, lines 97-100 > > <https://reviews.apache.org/r/45926/diff/1/?file=1337076#file1337076line97> > > > > Might be nice to note that this is ignored if `flags.shell` is false. > > Alexander Rukletsov wrote: > It's true for the _current_ code in mesos-execute, but not true for > Mesos. Moreover, there is a patch in the works > (https://reviews.apache.org/r/44441/) which adds support for this.
These flags are only used by `mesos-execute` right? You could just surface the TODO in the code into the flag. (And r44441 can replace the TODO.) - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45926/#review127827 ----------------------------------------------------------- On April 11, 2016, noon, Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45926/ > ----------------------------------------------------------- > > (Updated April 11, 2016, noon) > > > Review request for mesos, Anand Mazumdar and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/cli/execute.cpp 763dd26c359d1dd92c6e0365e4808b673efb1f40 > > Diff: https://reviews.apache.org/r/45926/diff/ > > > Testing > ------- > > See the last patch in the chain: https://reviews.apache.org/r/45927/ > > > Thanks, > > Alexander Rukletsov > >
