----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46042/#review128189 -----------------------------------------------------------
Ship it! Ship It! - Michael Park On April 11, 2016, 6:06 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46042/ > ----------------------------------------------------------- > > (Updated April 11, 2016, 6:06 p.m.) > > > Review request for mesos, Artem Harutyunyan and Michael Park. > > > Repository: mesos > > > Description > ------- > > While reading the lines of the commit message we currently mangle > contained backslashes. This has the effect that we cannot e.g., > continue lines in code samples. > > This patch preserves existing backslashes when reading the commit > message. > > > Diffs > ----- > > support/hooks/commit-msg d3f10c886a654aa8d8364faddf2e50dc7fe82058 > > Diff: https://reviews.apache.org/r/46042/diff/ > > > Testing > ------- > > I tested this with the following commit message: > > This is a test. > > Currently we cannot continue lines as they appear as one line to the > line length checker. > > Example: > > sed -e 's/1/2/g' \ > -e 's/2/3/g' \ > -e 's/3/4/g' \ > -e 's/4/5/g' \ > -e 's/5/6/g' \ > -e 's/6/7/g' \ > -e 's/7/8/g' \ > -e 's/8/9/g' \ > -e 's/9/0/g' \ > file.txt > > Without this fix the example contained in the commit message will be > interpreted as a single line leading to it being rejected; with the fix the > line breaks are preserved and can be committed. > > > Thanks, > > Benjamin Bannier > >
