-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45922/#review128356
-----------------------------------------------------------




docs/configuration.md (line 867)
<https://reviews.apache.org/r/45922/#comment191787>

    This seems not relevant at the agent (register framework). If it is just 
used a placeholder please remove.



src/local/local.cpp (line 241)
<https://reviews.apache.org/r/45922/#comment191792>

    Add a comment that this (master flag) is currently also used for the agent 
authorizer.



src/local/local.cpp (line 397)
<https://reviews.apache.org/r/45922/#comment191791>

    Could we add a comment here that this is currently the same authorizer as 
the master i.e. is already checked byt the Master code?



src/slave/flags.hpp (line 102)
<https://reviews.apache.org/r/45922/#comment191793>

    Do we have a particular order here?



src/slave/main.cpp (line 26)
<https://reviews.apache.org/r/45922/#comment191790>

    This should go above mesos/master/detector or?



src/slave/main.cpp (line 293)
<https://reviews.apache.org/r/45922/#comment191800>

    The blank lines between calls are inconsistent with 
    src/tests/cluster.cpp below.



src/tests/cluster.cpp (line 395)
<https://reviews.apache.org/r/45922/#comment191801>

    blank lines inconsistent with main.cpp above.



src/tests/cluster.cpp (line 406)
<https://reviews.apache.org/r/45922/#comment191797>

    We only create an authorizer if the acls flags are set, correct?
    In the case of no acl flags it means the local authorizer permits 
everything and hence we don't have to specify it (i.e. authorizer((None())). 
Ist that correct?
    
    In that case maybe "Creating default '" << authorizerName << "' authorizer 
as acls flags are are set"?


- Joerg Schad


On April 8, 2016, 2:25 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45922/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 2:25 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-5142
>     https://issues.apache.org/jira/browse/MESOS-5142
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added agent authorization flags.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 309a5a05eab386c8943ba6bdee8d5efeb448aa0c 
>   src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
>   src/master/flags.cpp e522499586b731d522180f171731a9dd38b8344c 
>   src/slave/constants.hpp 449c8cd9f43f71b4612023eb463969e9db0bc960 
>   src/slave/flags.hpp 4236b7fe40b9aa26d57b651be06a0e36037f65c6 
>   src/slave/flags.cpp 7164afef9c82a9bba0f137d7387c3569912b6599 
>   src/slave/main.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48 
>   src/slave/slave.hpp 76f3aff394e5cecc54dcb3065cb872e238bc228e 
>   src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3 
>   src/tests/cluster.hpp 39ca15e3cc2f4f2ac9b8a73482c2bd945b1824e3 
>   src/tests/cluster.cpp 7e488d28b7a0d3bef9cd76bf7df2de4822256ef6 
>   src/tests/mesos.cpp 1b7a8fd703b90d77ffa3df079bdc2744752caac6 
> 
> Diff: https://reviews.apache.org/r/45922/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Reply via email to