> On April 12, 2016, 9:31 a.m., Adam B wrote: > > src/slave/flags.cpp, lines 446-449 > > <https://reviews.apache.org/r/45922/diff/3/?file=1337114#file1337114line446> > > > > I'd rather have no example than a confusing/invalid example. We can add > > an example after we have at least one ACL
+1 > On April 12, 2016, 9:31 a.m., Adam B wrote: > > src/slave/main.cpp, line 301 > > <https://reviews.apache.org/r/45922/diff/3/?file=1337115#file1337115line301> > > > > It seems that by naming the flag `authorizers`, you've already decided > > that we want to add support for multiple authorizers Isn't that also implied by the parsing logic above/in the master/main.cpp? > On April 12, 2016, 9:31 a.m., Adam B wrote: > > src/tests/cluster.hpp, line 146 > > <https://reviews.apache.org/r/45922/diff/3/?file=1337118#file1337118line146> > > > > Why add this here instead of at the end? Do you expect 'authorizer' to > > be a more populer parameter than the ones after it? This also causes that you have to touch a lot of tests.... - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45922/#review128350 ----------------------------------------------------------- On April 8, 2016, 2:25 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45922/ > ----------------------------------------------------------- > > (Updated April 8, 2016, 2:25 p.m.) > > > Review request for mesos, Adam B and Alexander Rojas. > > > Bugs: MESOS-5142 > https://issues.apache.org/jira/browse/MESOS-5142 > > > Repository: mesos > > > Description > ------- > > Added agent authorization flags. > > > Diffs > ----- > > docs/configuration.md 309a5a05eab386c8943ba6bdee8d5efeb448aa0c > src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce > src/master/flags.cpp e522499586b731d522180f171731a9dd38b8344c > src/slave/constants.hpp 449c8cd9f43f71b4612023eb463969e9db0bc960 > src/slave/flags.hpp 4236b7fe40b9aa26d57b651be06a0e36037f65c6 > src/slave/flags.cpp 7164afef9c82a9bba0f137d7387c3569912b6599 > src/slave/main.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48 > src/slave/slave.hpp 76f3aff394e5cecc54dcb3065cb872e238bc228e > src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3 > src/tests/cluster.hpp 39ca15e3cc2f4f2ac9b8a73482c2bd945b1824e3 > src/tests/cluster.cpp 7e488d28b7a0d3bef9cd76bf7df2de4822256ef6 > src/tests/mesos.cpp 1b7a8fd703b90d77ffa3df079bdc2744752caac6 > > Diff: https://reviews.apache.org/r/45922/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
