> On April 12, 2016, 2:31 a.m., Adam B wrote:
> > docs/configuration.md, line 94
> > <https://reviews.apache.org/r/45922/diff/3/?file=1337109#file1337109line94>
> >
> >     Why would we need to support multiple authorizers? Would a particular 
> > request check two authorizers then and/or the results?
> >     Or are we somehow using one authorizer for some things and another for 
> > others? This could be explainable for the master's framework authz vs. http 
> > authz, but makes no sense for the agent.
> 
> Alexander Rojas wrote:
>     That was an original requirement on the master, since the original 
> crammd5 authorizer was supposed to come also in the multiple version. I think 
> we can, not only remove it here, but also in the master. I don't think we 
> will move onto the multiple authorizers anytime soon.

+1, although I dread deprecating the plural flag in master. I could live with 
it being singular on agent and plural on master, at least for this release; but 
I guess we should start deprecations ASAP if we have to wait 6mo before we can 
remove them.


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45922/#review128350
-----------------------------------------------------------


On April 8, 2016, 7:25 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45922/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 7:25 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-5142
>     https://issues.apache.org/jira/browse/MESOS-5142
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added agent authorization flags.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 309a5a05eab386c8943ba6bdee8d5efeb448aa0c 
>   src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
>   src/master/flags.cpp e522499586b731d522180f171731a9dd38b8344c 
>   src/slave/constants.hpp 449c8cd9f43f71b4612023eb463969e9db0bc960 
>   src/slave/flags.hpp 4236b7fe40b9aa26d57b651be06a0e36037f65c6 
>   src/slave/flags.cpp 7164afef9c82a9bba0f137d7387c3569912b6599 
>   src/slave/main.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48 
>   src/slave/slave.hpp 76f3aff394e5cecc54dcb3065cb872e238bc228e 
>   src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3 
>   src/tests/cluster.hpp 39ca15e3cc2f4f2ac9b8a73482c2bd945b1824e3 
>   src/tests/cluster.cpp 7e488d28b7a0d3bef9cd76bf7df2de4822256ef6 
>   src/tests/mesos.cpp 1b7a8fd703b90d77ffa3df079bdc2744752caac6 
> 
> Diff: https://reviews.apache.org/r/45922/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Reply via email to