----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44123/#review128413 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (line 464) <https://reviews.apache.org/r/44123/#comment191835> why does this return a `const` string by value? 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (lines 97 - 98) <https://reviews.apache.org/r/44123/#comment191836> We don't need to break after return. 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (lines 128 - 130) <https://reviews.apache.org/r/44123/#comment191837> Please put the `NOTE:` on a new line. 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (lines 184 - 185) <https://reviews.apache.org/r/44123/#comment191838> Where did `processes()` go? 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (lines 212 - 213) <https://reviews.apache.org/r/44123/#comment191839> 2 spaces for expression continuation. If an expression does not fit on 1 line, please leave a blank line after it. 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (lines 212 - 216) <https://reviews.apache.org/r/44123/#comment191840> Why does a `value_size` of 0 mean `None`? Is it not just the empty string? Can you add a comment here? - Joris Van Remoortere On April 11, 2016, 4:20 a.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44123/ > ----------------------------------------------------------- > > (Updated April 11, 2016, 4:20 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex > Clemmer, Joris Van Remoortere, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Stout: [1/2] Implemented assorted `os::` functions on Windows. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp > edaa76a5322d0bf60b7172405aa754b5aca95458 > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp > c48106e5905e3be0faeba7177ef534766089faff > > Diff: https://reviews.apache.org/r/44123/diff/ > > > Testing > ------- > > OSX: make check > > > Thanks, > > Daniel Pravat > >
