> On April 13, 2016, 4:24 a.m., Vinod Kone wrote: > > src/launcher/http_command_executor.cpp, lines 296-297 > > <https://reviews.apache.org/r/44424/diff/8/?file=1338080#file1338080line296> > > > > No need to capture taskId because you can get it from `task`?
I think just capuring `task` is not enough, because `task` will be set to `None()` when we receive `ACKNOWLEDGED` event, but after that we will still need `taskId`, e.g., in `reap()`, or when we receive `KILL` or `SHUTDOWN` event. > On April 13, 2016, 4:24 a.m., Vinod Kone wrote: > > src/launcher/http_command_executor.cpp, line 415 > > <https://reviews.apache.org/r/44424/diff/8/?file=1338080#file1338080line415> > > > > Instead of using underscores, the older version, where it explicitly > > uses fs:: namespace, looks cleaner. Agree. > On April 13, 2016, 4:24 a.m., Vinod Kone wrote: > > src/launcher/http_command_executor.cpp, line 764 > > <https://reviews.apache.org/r/44424/diff/8/?file=1338080#file1338080line764> > > > > does the compiler require this namespacing to disambiguate? No, thanks for catching this! > On April 13, 2016, 4:24 a.m., Vinod Kone wrote: > > src/launcher/http_command_executor.cpp, lines 804-809 > > <https://reviews.apache.org/r/44424/diff/8/?file=1338080#file1338080line804> > > > > Lets fix this hack now that the executor receives acknowledgements for > > status updates. > > > > The executor can terminate after it receives an ACK for a terminal > > status update. Can you add a TODO here and fix it in a separate review? Agree, will post a separate patch for it soon. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44424/#review128522 ----------------------------------------------------------- On April 9, 2016, 4:40 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44424/ > ----------------------------------------------------------- > > (Updated April 9, 2016, 4:40 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-3558 > https://issues.apache.org/jira/browse/MESOS-3558 > > > Repository: mesos > > > Description > ------- > > Updated http_command_executor.cpp to use v1 API. > > > Diffs > ----- > > src/launcher/http_command_executor.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44424/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
