> On Abr. 9, 2016, 1:34 a.m., Vinod Kone wrote: > > support/docker_build.sh, line 125 > > <https://reviews.apache.org/r/45668/diff/5/?file=1337908#file1337908line125> > > > > See the ASF CI build error on the attached ticket. > > > > I think specifying configuration options this way doesn't work with > > cmake. > > > > Not sure what the right way is. cc @hausdorff > > Juan Larriba wrote: > export CONFIGURATION='-DVERBOSE="1"' > > Vinod Kone wrote: > We need to make the CONFIGURATION value work with both autotools and > cmake. Can you update the script to append "-D" to CONFIGURATION (you might > need to append it once for each configuration value)? Also, test it locally > with both autotools and cmake with the following CONFIGURATION value > (--verbose --enable_libevent)
The configuration options for autotools and cmake have a completely different syntax, so I do not see the point in translating the autotools configuration options to cmake options. I can do the translation, but don't you think it would be more elegant to pass the adequate configuration options for the used buildtools? - Juan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review127944 ----------------------------------------------------------- On Abr. 8, 2016, 11:26 p.m., Juan Larriba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45668/ > ----------------------------------------------------------- > > (Updated Abr. 8, 2016, 11:26 p.m.) > > > Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone. > > > Bugs: MESOS-5101 > https://issues.apache.org/jira/browse/MESOS-5101 > > > Repository: mesos > > > Description > ------- > > Enable CMake build for Linux as new CONFIGURATOR option. > > > Enable CMake build for Linux as a BUILDTOOL option. > > > Enable CMake build for Linux as a BUILDTOOL option. > > > Enable CMake build for Linux as a BUILDTOOL option. > > > Enable CMake build for Linux as a BUILDTOOL option. > > > Enable CMake build for Linux as a BUILDTOOL option. > > > Diffs > ----- > > support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d > > Diff: https://reviews.apache.org/r/45668/diff/ > > > Testing > ------- > > Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both > cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in > centos:7 only gcc. > > > Thanks, > > Juan Larriba > >
