----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/#review129016 -----------------------------------------------------------
src/CMakeLists.txt (line 145) <https://reviews.apache.org/r/45360/#comment192479> s/volume_client/driver.cpp No need for the 'volume' since it's already in the directory. src/slave/containerizer/mesos/isolators/docker/volume/volume_client.hpp (line 31) <https://reviews.apache.org/r/45360/#comment192480> Remove this. src/slave/containerizer/mesos/isolators/docker/volume/volume_client.hpp (line 37) <https://reviews.apache.org/r/45360/#comment192481> s/VolumeClient/DockerVolumeDriverClient/ src/slave/containerizer/mesos/isolators/docker/volume/volume_client.hpp (line 46) <https://reviews.apache.org/r/45360/#comment192483> Why virtual? Let's not make them virtual yet. src/slave/containerizer/mesos/isolators/docker/volume/volume_client.hpp (line 52) <https://reviews.apache.org/r/45360/#comment192482> ``` // Returns the path of the mount point. Future<string> mount( const string& driver, const string& name, const hashmap<string, string>& options); ``` src/slave/containerizer/mesos/isolators/docker/volume/volume_client.hpp (line 57) <https://reviews.apache.org/r/45360/#comment192484> ``` Future<Nothing> unmount( const string& driver, const string& name); ``` - Jie Yu On April 14, 2016, 6:05 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45360/ > ----------------------------------------------------------- > > (Updated April 14, 2016, 6:05 a.m.) > > > Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and > Jie Yu. > > > Repository: mesos > > > Description > ------- > > Added volume client for mount and unmount. > > > Diffs > ----- > > src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 > src/Makefile.am 139935fb40f8986427c85537a400ff945e54433f > src/slave/containerizer/mesos/isolators/docker/volume/volume_client.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/docker/volume/volume_client.cpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/45360/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >