> On 四月 19, 2016, 10:37 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp, line 41 > > <https://reviews.apache.org/r/45360/diff/8/?file=1346544#file1346544line41> > > > > Do you want to use `const Option<string>& dvdcliPath` here? The idea is > > that if not specified, the client will just use 'dvdcli' in $PATH. You want > > to use os::which to do a check in 'create' to make sure it's there if > > dvdcliPath is not specified.
So you mean that we still need an agent flag to speicify the dvdcli path as an option? - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/#review129573 ----------------------------------------------------------- On 四月 15, 2016, 2:43 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45360/ > ----------------------------------------------------------- > > (Updated 四月 15, 2016, 2:43 p.m.) > > > Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and > Jie Yu. > > > Repository: mesos > > > Description > ------- > > Added volume driver client for mount and unmount. > > > Diffs > ----- > > src/CMakeLists.txt 06f58c4a88e3c527df727df1efe11ed3ab77efa8 > src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 > src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/45360/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
