> On 四月 19, 2016, 10:37 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp, line 68 > > <https://reviews.apache.org/r/45360/diff/8/?file=1346544#file1346544line68> > > > > Why 'static'? If it's static, can that be a file local helper in > > driver.cpp? > > Guangya Liu wrote: > I do not have strong intention to use `static` here but just following > same coding style as docker: > https://github.com/apache/mesos/blob/master/src/docker/docker.hpp#L184-L189 , > I'm OK to remove it for now.
This method is now removed. > On 四月 19, 2016, 10:37 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp, lines > > 72-75 > > <https://reviews.apache.org/r/45360/diff/8/?file=1346544#file1346544line72> > > > > Ditto. This method is now removed. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/#review129573 ----------------------------------------------------------- On 四月 15, 2016, 2:43 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45360/ > ----------------------------------------------------------- > > (Updated 四月 15, 2016, 2:43 p.m.) > > > Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and > Jie Yu. > > > Repository: mesos > > > Description > ------- > > Added volume driver client for mount and unmount. > > > Diffs > ----- > > src/CMakeLists.txt 06f58c4a88e3c527df727df1efe11ed3ab77efa8 > src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 > src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/45360/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
