----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46344/#review130185 -----------------------------------------------------------
3rdparty/libprocess/include/process/windows/winsock.hpp (line 28) <https://reviews.apache.org/r/46344/#comment193869> brace on new line. 3rdparty/libprocess/include/process/windows/winsock.hpp (line 31) <https://reviews.apache.org/r/46344/#comment193874> no need for space between `{ }` 3rdparty/libprocess/include/process/windows/winsock.hpp (line 38) <https://reviews.apache.org/r/46344/#comment193870> can you put the initialization on a new line: ``` Class( arg1, arg2) : arg1(arg1) { } ``` brace on new line. 3rdparty/libprocess/include/process/windows/winsock.hpp (line 44) <https://reviews.apache.org/r/46344/#comment193871> brace on new line. 3rdparty/libprocess/include/process/windows/winsock.hpp (lines 49 - 51) <https://reviews.apache.org/r/46344/#comment193875> members below functions. 3rdparty/libprocess/include/process/windows/winsock.hpp (line 51) <https://reviews.apache.org/r/46344/#comment193876> holding a reference to a lambda like this that is not executed immediately is extremely dangerous. Please take this by value. 3rdparty/libprocess/include/process/windows/winsock.hpp (line 56) <https://reviews.apache.org/r/46344/#comment193872> brace on new line. 3rdparty/libprocess/include/process/windows/winsock.hpp (lines 56 - 68) <https://reviews.apache.org/r/46344/#comment193877> Why not use the `Once` pattern used for initialization in the rest of the code base. Take a look at `process.cpp` 3rdparty/libprocess/include/process/windows/winsock.hpp (line 74) <https://reviews.apache.org/r/46344/#comment193873> brace on new line. - Joris Van Remoortere On April 18, 2016, 7:21 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46344/ > ----------------------------------------------------------- > > (Updated April 18, 2016, 7:21 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3656 > https://issues.apache.org/jira/browse/MESOS-3656 > > > Repository: mesos > > > Description > ------- > > Libprocess: Created Winsock class to handle WSAStartup/WSACleanup. > > > Diffs > ----- > > 3rdparty/libprocess/include/Makefile.am > 47f5347988a61140c87bcd329e25d5a4d52e17a0 > 3rdparty/libprocess/include/process/windows/winsock.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46344/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
