----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46620/#review130422 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp (line 45) <https://reviews.apache.org/r/46620/#comment194169> If this was `const` it would be much easier to reason how this works with all the usage sites. 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (line 379) <https://reviews.apache.org/r/46620/#comment194171> Here and at similar call sites: since you provide an `operator<<` directly using `stringify(name)` here and elsewhere seems more consistent to me. - Benjamin Bannier On April 25, 2016, 7:43 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46620/ > ----------------------------------------------------------- > > (Updated April 25, 2016, 7:43 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-5271 > https://issues.apache.org/jira/browse/MESOS-5271 > > > Repository: mesos > > > Description > ------- > > This sets up the stage to add metadata to the name (e.g., deprecated). > This will be used to add deprecation support subsequently. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp > 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp > c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 > > Diff: https://reviews.apache.org/r/46620/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
