> On April 29, 2016, 7:27 p.m., Michael Park wrote: > > (1) Just so I understand, is this a necessary introduction? or is it an > > improvement? > > (2) In some parts, we access the `name.value` directly, and other times we > > use `stringify(name)`. From the implementation it looks like they yield the > > same result, but are there different semantic intentions behind the uses?
This is a necessary introduction for adding meta data to name (e.g., deprecation status). I killed the output operator overload and used name.value everywhere to avoid confusion. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46620/#review131166 ----------------------------------------------------------- On April 29, 2016, 3:25 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46620/ > ----------------------------------------------------------- > > (Updated April 29, 2016, 3:25 a.m.) > > > Review request for mesos, Ben Mahler, Greg Mann, and Michael Park. > > > Bugs: MESOS-5271 > https://issues.apache.org/jira/browse/MESOS-5271 > > > Repository: mesos > > > Description > ------- > > This sets up the stage to add metadata to the name (e.g., deprecated). > This will be used to add deprecation support subsequently. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp > 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp > c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 > > Diff: https://reviews.apache.org/r/46620/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
