> On May 5, 2016, 9:45 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp, line 40
> > <https://reviews.apache.org/r/46620/diff/4/?file=1367881#file1367881line40>
> >
> >     (1) Can we make this `private` and add a `const std::string& get() 
> > const { return value; }`
> >     (2) `s/value/value_/`
> 
> Vinod Kone wrote:
>     I wanted Name to be a simple struct which encapsulates some information 
> (just like Flags below). So didn't add any getter etc. Do you feel strongly 
> about the getter?

also note that get() that retuns the value is a bit weird because in a later 
patch this struct will also contain a deprecated boolean flag.


> On May 5, 2016, 9:45 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp, lines 34-38
> > <https://reviews.apache.org/r/46620/diff/4/?file=1367881#file1367881line34>
> >
> >     `s/_value/value/`

see below.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46620/#review131946
-----------------------------------------------------------


On April 30, 2016, 1:56 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46620/
> -----------------------------------------------------------
> 
> (Updated April 30, 2016, 1:56 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.
> 
> 
> Bugs: MESOS-5271
>     https://issues.apache.org/jira/browse/MESOS-5271
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This sets up the stage to add metadata to the name (e.g., deprecated).
> This will be used to add deprecation support subsequently.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
> 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
> 
> Diff: https://reviews.apache.org/r/46620/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Reply via email to