> On April 22, 2016, 1:22 a.m., Adam B wrote: > > src/slave/slave.hpp, lines 471-472 > > <https://reviews.apache.org/r/46319/diff/2/?file=1348482#file1348482line471> > > > > How did this come up? The original `_statistics()` is not static, and > > it had no issues. > > Benjamin Bannier wrote: > The original `statistics` did not make any use of member data in any of > the `defer`ed actions (all the used data came from some > `Future<ResourceUsage>` directly passed into the callback; the call of > `slave->self()` was not executed in the `defer`ed action). Now here we need > to access a rate limiter which is a member of `Http` which in turn might go > away before `_statistics` is executed.
And now that `_statistics()` is synchronous and no longer uses the limiter, do we still need to worry about this? - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46319/#review130057 ----------------------------------------------------------- On April 25, 2016, 7:16 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46319/ > ----------------------------------------------------------- > > (Updated April 25, 2016, 7:16 a.m.) > > > Review request for mesos, Adam B, Alexander Rojas, and Jan Schlicht. > > > Bugs: MESOS-5164 > https://issues.apache.org/jira/browse/MESOS-5164 > > > Repository: mesos > > > Description > ------- > > Added authorization to agents' `/monitor/statistics` endpoints. > > > Diffs > ----- > > src/slave/http.cpp 537736d1fe42e8150bad91326299ef9a17041a8e > src/slave/slave.hpp 20a4bcd0bb9dad06ea81fc4ad9b2fa462c69d2c5 > src/tests/slave_authorization_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46319/diff/ > > > Testing > ------- > > make check (OS X, clang w/o optimization) > > > Thanks, > > Benjamin Bannier > >
