> On April 25, 2016, 12:57 p.m., Alexander Rojas wrote: > > src/slave/http.cpp, lines 647-649 > > <https://reviews.apache.org/r/46319/diff/4/?file=1359329#file1359329line647> > > > > I was thinking that it makes sense to pull up the limiter related logic > > to `statistics()` so that method prepares everything up, while > > `_statistics()` only has logic related to build the response.
Good point! This also allows us to make `_statistics` purely synchronously which simplifies handling of `Future` failure scenarios. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46319/#review130385 ----------------------------------------------------------- On April 25, 2016, 4:16 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46319/ > ----------------------------------------------------------- > > (Updated April 25, 2016, 4:16 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, and Jan Schlicht. > > > Bugs: MESOS-5164 > https://issues.apache.org/jira/browse/MESOS-5164 > > > Repository: mesos > > > Description > ------- > > Added authorization to agents' `/monitor/statistics` endpoints. > > > Diffs > ----- > > src/slave/http.cpp 537736d1fe42e8150bad91326299ef9a17041a8e > src/slave/slave.hpp 20a4bcd0bb9dad06ea81fc4ad9b2fa462c69d2c5 > src/tests/slave_authorization_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46319/diff/ > > > Testing > ------- > > make check (OS X, clang w/o optimization) > > > Thanks, > > Benjamin Bannier > >
