> On April 26, 2016, 8:53 a.m., Adam B wrote: > > src/slave/http.cpp, lines 630-638 > > <https://reviews.apache.org/r/46319/diff/5/?file=1359588#file1359588line630> > > > > Seems like these lines need to be indented more.
Indeed they need to be and now are. > On April 26, 2016, 8:53 a.m., Adam B wrote: > > src/slave/http.cpp, line 641 > > <https://reviews.apache.org/r/46319/diff/5/?file=1359588#file1359588line641> > > > > Is this always an authoriaztion error/warning? Couldn't this also be a > > failure from limiter->acquire() or Slave::usage? Good catch. Now we emit `"Could not collect statistics: "` .... - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46319/#review130549 ----------------------------------------------------------- On April 26, 2016, 9:59 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46319/ > ----------------------------------------------------------- > > (Updated April 26, 2016, 9:59 a.m.) > > > Review request for mesos, Adam B, Alexander Rojas, and Jan Schlicht. > > > Bugs: MESOS-5164 > https://issues.apache.org/jira/browse/MESOS-5164 > > > Repository: mesos > > > Description > ------- > > Added authorization to agents' `/monitor/statistics` endpoints. > > > Diffs > ----- > > src/slave/http.cpp 537736d1fe42e8150bad91326299ef9a17041a8e > src/slave/slave.hpp 57b18882e30e44dcc40449b0e3be8ee970c45bc8 > src/tests/slave_authorization_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46319/diff/ > > > Testing > ------- > > make check (OS X, clang w/o optimization) > > > Thanks, > > Benjamin Bannier > >
