-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46319/#review130756
-----------------------------------------------------------



Looking good. One more round.


src/slave/http.cpp (line 629)
<https://reviews.apache.org/r/46319/#comment194635>

    Is there any standard for what order these [pid, limiter, request] should 
go in?



src/tests/slave_authorization_tests.cpp (line 179)
<https://reviews.apache.org/r/46319/#comment194637>

    { belongs on newline.



src/tests/slave_authorization_tests.cpp (line 187)
<https://reviews.apache.org/r/46319/#comment194638>

    "Prefer trailing underscores for use as member fields", so you've got this 
reversed.



src/tests/slave_authorization_tests.cpp (lines 204 - 207)
<https://reviews.apache.org/r/46319/#comment194639>

    I thought this was done in SetUp() now



src/tests/slave_authorization_tests.cpp (lines 252 - 254)
<https://reviews.apache.org/r/46319/#comment194640>

    How is this testing with "no authorizer"? Doesn't SetUp use MockAuthorizer? 
Looks like MockAuthorizer::authorized() returns true by default. Might as well 
just remove this test.


- Adam B


On April 27, 2016, 2 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46319/
> -----------------------------------------------------------
> 
> (Updated April 27, 2016, 2 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Jan Schlicht.
> 
> 
> Bugs: MESOS-5164
>     https://issues.apache.org/jira/browse/MESOS-5164
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added authorization to agents' `/monitor/statistics` endpoints.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp 537736d1fe42e8150bad91326299ef9a17041a8e 
>   src/slave/slave.hpp 57b18882e30e44dcc40449b0e3be8ee970c45bc8 
>   src/tests/slave_authorization_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46319/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X, clang w/o optimization)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to