This is an automatically generated e-mail. To reply, visit:

(Updated May 3, 2016, 9:41 a.m.)

Review request for mesos and Joris Van Remoortere.


Remove change to debugging VLOG.

Bugs: MESOS-5144

Repository: mesos


Without this change, `finalize()` terminates processes in the order
that they happen to be found when iterating over the `processes`
map. That means that if the GarbageCollector process is terminated
while any GC-managed processes are still running, those processes
will not be GC'd (i.e., they will be leaked).

Fix this by skipping the garbage collector process when iterating
over `processes` in `finalize()`, and then only terminating it after
all other processes have been terminated.

Diffs (updated)

  3rdparty/libprocess/src/process.cpp dcaa64633d1eea330649c563635642928164d73c 

Diff: https://reviews.apache.org/r/45999/diff/


make check

Confirmed reduction of leaked memory via ASAN on Linux/amd64.


Neil Conway

Reply via email to