----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46107/#review131527 -----------------------------------------------------------
include/mesos/appc/spec.proto (line 71) <https://reviews.apache.org/r/46107/#comment195542> I think the message ids should ordered by their order in the spec (see `https://github.com/appc/spec/blob/master/spec/aci.md`). So `app` should be `5`. But we have `annotation` labeled 5 unfortunately. In `App`, lets try to follow the order specified in the spec. So IMO, `workingDirectory` should be atleast `6`. include/mesos/slave/isolator.proto (line 22) <https://reviews.apache.org/r/46107/#comment195539> Please sort the include files in alphabetical order. So it would be: ``` import "mesos/appc/spec.proto"; import "mesos/docker/v1.proto"; ``` include/mesos/slave/isolator.proto (line 94) <https://reviews.apache.org/r/46107/#comment195537> I would place this message above the `Docker` messgae. - Jojy Varghese On April 12, 2016, 6:32 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46107/ > ----------------------------------------------------------- > > (Updated April 12, 2016, 6:32 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Add Appc runtime spec for command, working directory and environment. > > > Diffs > ----- > > include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 > include/mesos/slave/isolator.proto 60a9bb637e12593a97ed1a7c510ebccd4e5a9615 > > Diff: https://reviews.apache.org/r/46107/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Srinivas Brahmaroutu > >
