-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47069/#review132246
-----------------------------------------------------------



In the description: `/protobug/protobuf/`, also, I would avoid starting the 
description with _As…_


src/common/protobuf_utils.cpp (line 185)
<https://reviews.apache.org/r/47069/#comment196438>

    Not yours but I die a little every time I see a variable named with one 
letter.


- Alexander Rojas


On May 6, 2016, 10:33 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47069/
> -----------------------------------------------------------
> 
> (Updated May 6, 2016, 10:33 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> As the LocalAuthorizer will use the OS `user` for
> authorization of tasks we add it to the `Task` protobug
> message. Note that the master stores `Task` (as opposed
> to `TaskInfo`) for running and completed tasks.
> 
> 
> Diffs
> -----
> 
>   src/common/protobuf_utils.cpp 4f4711d54c471922f1a103310d4d360e41a99870 
>   src/messages/messages.proto e0f1fca92d3ea8c29c095da31653c317873a934c 
> 
> Diff: https://reviews.apache.org/r/47069/diff/
> 
> 
> Testing
> -------
> 
> tested entire check.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Reply via email to