-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47069/#review134250
-----------------------------------------------------------




src/common/http.cpp (lines 288 - 290)
<https://reviews.apache.org/r/47069/#comment198941>

    This has inconsistent behavior with `void json(JSON::ObjectWriter* writer, 
const Task& task);`. I think we want to the behavior in `json` and leave `user` 
out if it's not set?


- Michael Park


On May 21, 2016, 8:32 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47069/
> -----------------------------------------------------------
> 
> (Updated May 21, 2016, 8:32 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The LocalAuthorizer might use the OS \`user\` for
> authorization of tasks, so we add it to the \`Task\` protobuf
> message. Note that the master stores \`Task\` (as opposed
> to \`TaskInfo\`) for running and completed tasks.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 887ffe9c5f04e25539a4c6b3d52ce5299c65e8d3 
>   src/common/http.cpp ad6a4b44af3ec847a3a6c0839a88fba18cda5011 
>   src/common/protobuf_utils.cpp 4f4711d54c471922f1a103310d4d360e41a99870 
>   src/common/type_utils.cpp 037c4336276258d671d0b1bf66cdab50b5bf9fb8 
>   src/tests/common/http_tests.cpp 300f7cc21239b7d8727f7f0f02963f1af0dc80d7 
> 
> Diff: https://reviews.apache.org/r/47069/diff/
> 
> 
> Testing
> -------
> 
> tested entire chain.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Reply via email to