> On May 10, 2016, 8:02 a.m., Alexander Rukletsov wrote:
> > Hey Tomasz, thanks a lot for the patch! Could you please leave a comment in 
> > test description explaining the necessity for scopes, similar to what you 
> > write in the description? This will help people understand reasons for 
> > scopes without running `git blame`. Also, I believe you did some testing, 
> > could you please describe it in the "testing done" section?

Done


- Tomasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47161/#review132388
-----------------------------------------------------------


On May 10, 2016, 9:02 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47161/
> -----------------------------------------------------------
> 
> (Updated May 10, 2016, 9:02 a.m.)
> 
> 
> Review request for mesos and Kapil Arya.
> 
> 
> Bugs: MESOS-2201
>     https://issues.apache.org/jira/browse/MESOS-2201
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Per design leveldb can only be held open by a single process
> at the time. In tests two instances of replica log were created
> and lived at same time. Now there is one instance that create
> db and second that restore it.
> 
> 
> Diffs
> -----
> 
>   src/tests/log_tests.cpp 4cd6bc359d481c065d9647b3d5f0154cb5cb2503 
> 
> Diff: https://reviews.apache.org/r/47161/diff/
> 
> 
> Testing
> -------
> 
> Tested with leveldb v1.18 before this patch tests failed with ` error: lock 
> already held by process` after this patch all tests passed.
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Reply via email to