> On May 10, 2016, 3:13 p.m., Kapil Arya wrote: > > src/tests/log_tests.cpp, lines 444-446 > > <https://reviews.apache.org/r/47161/diff/2/?file=1377747#file1377747line444> > > > > Move this description before the first scope level? > > > > And maybe, add a comment about this test itself?
Moved the description. IMO name of this tests already describe what happen inside, no need for clarification. - Tomasz ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47161/#review132445 ----------------------------------------------------------- On May 10, 2016, 9:02 a.m., Tomasz Janiszewski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47161/ > ----------------------------------------------------------- > > (Updated May 10, 2016, 9:02 a.m.) > > > Review request for mesos and Kapil Arya. > > > Bugs: MESOS-2201 > https://issues.apache.org/jira/browse/MESOS-2201 > > > Repository: mesos > > > Description > ------- > > Per design leveldb can only be held open by a single process > at the time. In tests two instances of replica log were created > and lived at same time. Now there is one instance that create > db and second that restore it. > > > Diffs > ----- > > src/tests/log_tests.cpp 4cd6bc359d481c065d9647b3d5f0154cb5cb2503 > > Diff: https://reviews.apache.org/r/47161/diff/ > > > Testing > ------- > > Tested with leveldb v1.18 before this patch tests failed with ` error: lock > already held by process` after this patch all tests passed. > > > Thanks, > > Tomasz Janiszewski > >