> On Maj 11, 2016, 12:21 rano, Alexander Rukletsov wrote: > > src/tests/log_tests.cpp, lines 450-452 > > <https://reviews.apache.org/r/47161/diff/4/?file=1378321#file1378321line450> > > > > How about this comment for clarity? > > ``` > > // By design only a single process can access leveldb at a time. In > > // this test, two instances of log replica need to open a connection > > // to the leveldb. By introducing scope levels we ensure that the > > first > > // instance is destructed and hence closes the connection before the > > // second instance opens it. > > ```
Thanks - Tomasz ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47161/#review132572 ----------------------------------------------------------- On Maj 10, 2016, 5:50 po południu, Tomasz Janiszewski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47161/ > ----------------------------------------------------------- > > (Updated Maj 10, 2016, 5:50 po południu) > > > Review request for mesos and Kapil Arya. > > > Bugs: MESOS-2201 > https://issues.apache.org/jira/browse/MESOS-2201 > > > Repository: mesos > > > Description > ------- > > Per design leveldb can only be held open by a single process > at the time. In tests two instances of replica log were created > and lived at same time. Now there is one instance that create > db and second that restore it. > > > Diffs > ----- > > src/tests/log_tests.cpp 4cd6bc359d481c065d9647b3d5f0154cb5cb2503 > > Diff: https://reviews.apache.org/r/47161/diff/ > > > Testing > ------- > > Tested with leveldb v1.18 before this patch tests failed with ` error: lock > already held by process` after this patch all tests passed. > > > Thanks, > > Tomasz Janiszewski > >
