----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47168/#review133155 -----------------------------------------------------------
3rdparty/stout/include/stout/os/windows/kill.hpp (lines 47 - 48) <https://reviews.apache.org/r/47168/#comment197446> new line between closing function and closing namespace 3rdparty/stout/include/stout/windows.hpp (line 20) <https://reviews.apache.org/r/47168/#comment197445> Missing period `.`. - Joris Van Remoortere On May 13, 2016, 4:01 a.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47168/ > ----------------------------------------------------------- > > (Updated May 13, 2016, 4:01 a.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van > Remoortere, and Michael Park. > > > Bugs: MESOS-5375 > https://issues.apache.org/jira/browse/MESOS-5375 > > > Repository: mesos > > > Description > ------- > > Windows: Implemented `kill`. > > > Diffs > ----- > > 3rdparty/stout/include/Makefile.am 9b39ce32c0269479066cf7991afaeed65d8ab547 > 3rdparty/stout/include/stout/os/kill.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/posix/kill.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/windows/kill.hpp PRE-CREATION > 3rdparty/stout/include/stout/windows.hpp > a7a59e78575e1456b4e14d18ac97f51dd23d794e > > Diff: https://reviews.apache.org/r/47168/diff/ > > > Testing > ------- > > Windows: build/test w/ Marathon > > > Thanks, > > Daniel Pravat > >
