----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47168/#review132957 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/kill.hpp (lines 24 - 25) <https://reviews.apache.org/r/47168/#comment197232> Missing periods `.`. 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp (lines 18 - 19) <https://reviews.apache.org/r/47168/#comment197230> Alphabetize. - Joris Van Remoortere On May 10, 2016, 11:34 p.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47168/ > ----------------------------------------------------------- > > (Updated May 10, 2016, 11:34 p.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van > Remoortere, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Windows: Implemented `kill`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 9b39ce32c0269479066cf7991afaeed65d8ab547 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/kill.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/kill.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/kill.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp > a7a59e78575e1456b4e14d18ac97f51dd23d794e > > Diff: https://reviews.apache.org/r/47168/diff/ > > > Testing > ------- > > Windows: build/test w/ Marathon > > > Thanks, > > Daniel Pravat > >
