> On May 10, 2016, 4:31 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, line 681
> > <https://reviews.apache.org/r/47169/diff/1/?file=1377777#file1377777line681>
> >
> >     Is there no extra information we can pass from this failure? No error 
> > code?
> >     Same question for the other errors returned below.

The error code is retrieved inside WindowsError.


> On May 10, 2016, 4:31 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, line 722
> > <https://reviews.apache.org/r/47169/diff/1/?file=1377777#file1377777line722>
> >
> >     No message?

This is autogenerated from GetLastError()


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47169/#review132465
-----------------------------------------------------------


On May 10, 2016, 9:57 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47169/
> -----------------------------------------------------------
> 
> (Updated May 10, 2016, 9:57 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Impemented  `killtree` using NT job objects.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/killtree.hpp 
> b075d625541ed6c10192e3e98bf399b38b69cdc5 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> 261768eace6ab09956f4a80e1ec5dba988d831e1 
> 
> Diff: https://reviews.apache.org/r/47169/diff/
> 
> 
> Testing
> -------
> 
> Windows: build/test with Marathon
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Reply via email to