----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47169/#review133157 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/include/stout/os/windows/killtree.hpp (line 34) <https://reviews.apache.org/r/47169/#comment197448> Do we need to manually convert to `Option`? 3rdparty/stout/include/stout/os/windows/killtree.hpp (lines 47 - 48) <https://reviews.apache.org/r/47169/#comment197447> new line - Joris Van Remoortere On May 13, 2016, 5:23 a.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47169/ > ----------------------------------------------------------- > > (Updated May 13, 2016, 5:23 a.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van > Remoortere, and Michael Park. > > > Bugs: MESOS-3639 > https://issues.apache.org/jira/browse/MESOS-3639 > > > Repository: mesos > > > Description > ------- > > Windows: Implemented `killtree` using NT job objects. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/windows/killtree.hpp > b075d625541ed6c10192e3e98bf399b38b69cdc5 > 3rdparty/stout/include/stout/windows/os.hpp > 261768eace6ab09956f4a80e1ec5dba988d831e1 > > Diff: https://reviews.apache.org/r/47169/diff/ > > > Testing > ------- > > Windows: build/test with Marathon > > > Thanks, > > Daniel Pravat > >
