----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47169/#review132960 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/killtree.hpp (lines 22 - 75) <https://reviews.apache.org/r/47169/#comment197236> I don't understand why this is: 1) Implemented here 2) Different from the pstree in os/pstree.hpp 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/killtree.hpp (line 80) <https://reviews.apache.org/r/47169/#comment197237> Missing period `.`. 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 668) <https://reviews.apache.org/r/47169/#comment197241> 2 lines between functions. 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (lines 669 - 673) <https://reviews.apache.org/r/47169/#comment197238> Grammar. Whitespace. 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 709) <https://reviews.apache.org/r/47169/#comment197240> 2 lines between functions 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (lines 710 - 714) <https://reviews.apache.org/r/47169/#comment197239> Grammar. - Joris Van Remoortere On May 10, 2016, 9:57 p.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47169/ > ----------------------------------------------------------- > > (Updated May 10, 2016, 9:57 p.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van > Remoortere, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Windows: Impemented `killtree` using NT job objects. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/killtree.hpp > b075d625541ed6c10192e3e98bf399b38b69cdc5 > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp > 261768eace6ab09956f4a80e1ec5dba988d831e1 > > Diff: https://reviews.apache.org/r/47169/diff/ > > > Testing > ------- > > Windows: build/test with Marathon > > > Thanks, > > Daniel Pravat > >
