-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/#review132753
-----------------------------------------------------------




3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (line 146)
<https://reviews.apache.org/r/46825/#comment197003>

    i see that you made all `add`s protected here.



3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (lines 147 - 
179)
<https://reviews.apache.org/r/46825/#comment197006>

    do we even need these overloads anymore? can't we just use the below 
overloads that use 'Flags' as a template parameter?



3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (lines 181 - 
188)
<https://reviews.apache.org/r/46825/#comment197004>

    why did you move this overload? makes is really hard to understand what 
changed. :(



3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (lines 286 - 
287)
<https://reviews.apache.org/r/46825/#comment197005>

    this comment needs to be updated.


- Vinod Kone


On April 29, 2016, 9:37 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46825/
> -----------------------------------------------------------
> 
> (Updated April 29, 2016, 9:37 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-3335
>     https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fully-typed all FlagsBase::add overloads.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
> 66e16abe914e2a1ee7599bab857ff478b7ec20dc 
>   3rdparty/libprocess/3rdparty/stout/tests/subcommand_tests.cpp 
> 9213d6b9faec30b5be320ab37ca29c2406c964ac 
> 
> Diff: https://reviews.apache.org/r/46825/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X clang-trunk w/o optimizations)
> 
> The mesos tests suite do not execute at all with an optimizing clang-trunk 
> since copying of the `map` inside `FlagsBase` reference random memory leading 
> to `SEGFAULTs`. With these patches all of `stout-tests` and 
> `libprocess-tests` can be executed, but some remaining failures persist in 
> `mesos-tests` (their number is reduced though).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to